Catch exception if close() in exception manager, throw another except…#1020
Draft
pprados wants to merge 1 commit intoencode:masterfrom
Draft
Catch exception if close() in exception manager, throw another except…#1020pprados wants to merge 1 commit intoencode:masterfrom
pprados wants to merge 1 commit intoencode:masterfrom
Conversation
Contributor
|
https://peps.python.org/pep-0008 contains clear advice to avoid catching BaseException. Why should that be ignored? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given this is a project maintained by volunteers, please read this template to not waste your time, or ours! 😁 -->
Summary
If some scenario, to close the program, the code catch en exception, and try to close itself. But, if this close generate and exception, the code crash with a stacktrace.
Checklist